Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[util.smartptr.enab]/8 and P0033R1 #1299

Closed
timsong-cpp opened this issue Dec 30, 2016 · 2 comments
Closed

[util.smartptr.enab]/8 and P0033R1 #1299

timsong-cpp opened this issue Dec 30, 2016 · 2 comments
Assignees
@jensmaurer

Comments

@timsong-cpp
Copy link
Contributor

Currently [util.smartptr.enab]/8 depicts:

Postconditions: r.get() == this.

This is a vestige from pre-P0033R1 days, when it was paragraph 9 in e.g., N4567; it references a nonexistent variable r.

I'd normally file an LWG issue for this, but it looks like that P0033R1's wording actually does seem to say this should be removed, because it says "Replace paragraphs 7, 8 and 9" (and this was paragraph 9 in N4567, as noted). The subsequent diff didn't include the paragraph, though.

Pinging @jwakely (since it's his paper).
@jensmaurer
Copy link
Member

Well, P0033R1 didn't show the Postcondition with strikeout.

Anyway, there's no "r" in sight here, and the prose edit instructions in P0033R1 seem clear enough to me.

jensmaurer added a commit to jensmaurer/draft that referenced this issue Jan 1, 2017
@jensmaurer
[util.smartptr.enab] Remove leftover postcondition after P0033R1.
fb47a91 
Fixes cplusplus#1299.
@jensmaurer jensmaurer mentioned this issue Jan 1, 2017
Merged
@jensmaurer jensmaurer self-assigned this Jan 1, 2017
jwakely pushed a commit that referenced this issue Jan 3, 2017
@jensmaurer @jwakely
[util.smartptr.enab] Remove leftover postcondition after P0033R1. (#1314
2416d45 
)

Fixes #1299.
@jwakely
Copy link
Member

jwakely commented Jan 3, 2017

Yes, that was meant to be struck out, I guess I missed it from the paper. Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwakely @timsong-cpp @jensmaurer