Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class.gslice.overview] Replace $$...$$ with \[...\]. #1334

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jan 5, 2017

The use of double dollars for math is an old TeX practice that is discouraged in LaTeX.

This patch removes the only two uses of double dollar math in the document.

No visual difference (because \[...\] is equivalent here).

(Incidentally, this helps my HTML version of the standard, because cxxdraft-htmlgen uses HaTeX, a Haskell LaTeX parsing library that does not support archaic double dollar math.)

@@ -8025,7 +8025,7 @@
template, which is one-dimensional.
The set of one-dimensional index values specified by a
\tcode{gslice}
are $$k = s + \sum_ji_jd_j$$
are \[k = s + \sum_ji_jd_j\]
Copy link
Contributor

@tkoeppe tkoeppe Jan 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, make this a bit easier to read:

\[ k = s + \sum_j i_j d_j \]

Also add spacing after \[ and after the commas below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Shall I also remove the comment on line 8029? Doesn't look too useful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. That must be a left-over from troff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

are $$k = s + \sum_ji_jd_j$$
% \$k = s + sum from j \{ i sub j d sub j \}\$
The set of one-dimensional index values specified by a \tcode{gslice} are

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, we didn't use to have paragraph breaks here originally, why did you introduce them?

Copy link
Contributor Author

@Eelis Eelis Jan 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just tried to make it consistent with the other one, which is also an equation in the middle of a sentence, and already had the empty lines around it. If empty lines around \[...\] introduce paragraph breaks that are unwanted in mid-sentence cases, I guess the empty lines should be removed there, as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they should both go. Both expressions are part of the single paragraph here, no breaks. (Even if the breaks don't show visually.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that, updated.

@tkoeppe tkoeppe merged commit 1357aed into cplusplus:master Jan 5, 2017
@Eelis Eelis deleted the doubledollar branch January 5, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants