Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rand.req.eng] Omit superfluous dollar-math wrapping inside \bigoh. #1340

Closed
wants to merge 1 commit into from

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jan 7, 2017

Compare: line 2070

@@ -1912,21 +1912,21 @@
with the same initial state
as all other default-constructed engines
of type \tcode{E}.
& \bigoh{$\mbox{size of state}$}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why \mbox and not \text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 9, 2017

Let's leave this for now. I can revise the section systematically if and when I get to it.

@tkoeppe tkoeppe closed this Jan 9, 2017
@Eelis
Copy link
Contributor Author

Eelis commented Jan 9, 2017

I'm curious, is that due to a policy that an issue in a line of code may only be fixed if all other potential issues on the same line are fixed at the same time?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 9, 2017

Just triaging the deluge of pull requests. I would make this change differently and probably will at some point, so I figured time is better spend on other things.

Eelis added a commit to Eelis/draft that referenced this pull request Jul 17, 2017
Eelis added a commit to Eelis/draft that referenced this pull request Jul 24, 2017
Eelis added a commit to Eelis/draft that referenced this pull request Jul 24, 2017
@Eelis Eelis deleted the bigohdollar branch July 3, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants