Capitalize examples where appropriate. #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eelis
commented
Jan 13, 2017
source/utilities.tex
Outdated
| @@ -5414,7 +5414,7 @@ | |||
| \pnum | |||
| Implementations should avoid the use of dynamically allocated memory for a small contained object. | |||
| \begin{example} | |||
| where the object constructed is holding only an \tcode{int}. | |||
| Where the object constructed is holding only an \tcode{int}. | |||
There was a problem hiding this comment.
(As an aside, grammar-wise it might be nice to rephrase this example.)
There was a problem hiding this comment.
Could you please leave this untouched in your change and open an edit issue for rephrasing this?
|
Otherwise, looks good to me. |
jwakely
reviewed
Jan 13, 2017
source/special.tex
Outdated
| @@ -33,7 +33,7 @@ | |||
| \pnum | |||
| Programs may explicitly refer to implicitly-declared special member functions. | |||
| \begin{example} | |||
| a program may explicitly call, take the address of or form a pointer to member | |||
| A program may explicitly call, take the address of or form a pointer to member | |||
There was a problem hiding this comment.
There should be a comma before "or" but I'll fix that separately.
Eelis
force-pushed
the
capitalexamples
branch
from
fc8e696
to
06a83ad
Compare
|
@Eelis: Rebase? |
Eelis
force-pushed
the
capitalexamples
branch
from
06a83ad
to
fac4c8e
Compare
|
Rebased |
|
Thanks, I've also added a matching rule to the style guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency.