Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[re] Remove whitespace before \colcol. #1358

Merged
merged 2 commits into from Jan 13, 2017
Merged

Conversation

cpplearner
Copy link
Contributor

No description provided.

@jensmaurer
Copy link
Member

jensmaurer commented Jan 13, 2017

Wait. We usually use "::", but sometimes we use \colcol, for no apparent reason. Ah, \colcol allows line breaks before and after the "::", which plain "::" doesn't.

But we have lots of places where we use ::\brk{}, not \colcol. Let's move that harmonizing discussion to a separate issue -> #1359.

@jensmaurer
Copy link
Member

The patch as proposed looks good to me.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 13, 2017

This seems like churn. I'd say if you want to make progress here, replace the \colcol with plain double colons while you're at it.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 13, 2017

Looks good, thanks. Can you just check quickly that this doesn't introduce any paragraph composition problems (overlong lines)? (E.g. by comparing the output of fgrep std.log -e Overfull -e .tex before and after.)

@cpplearner
Copy link
Contributor Author

No. The output is the same before and after.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 13, 2017

Thanks!

@tkoeppe tkoeppe merged commit 9ed3d36 into cplusplus:master Jan 13, 2017
@cpplearner cpplearner deleted the re branch January 13, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants