Remove stray whitespace after opening parentheses. #1364
Conversation
|
Any visual diffs? |
|
Yeah, these spaces are visible, so this fixes actual artifacts. |
|
Yes, right, do you have a screenshot? It looks sane. |
| @@ -15881,7 +15881,7 @@ | |||
| \tcode{is_constructible_v<T,}\br | |||
| \tcode{Args...>} is \tcode{true} and the variable | |||
| definition for \tcode{is_constructible}, as defined below, is known to call | |||
| no operation that is not trivial (~\ref{basic.types},~\ref{special}). & | |||
| no operation that is not trivial (\ref{basic.types},~\ref{special}). & | |||
There was a problem hiding this comment.
We usually do blah~(\ref so it looks as though the ~ just got put in the wrong place here. Do we want to move it rather than removing it?
There was a problem hiding this comment.
Oh yes, that's where that comes from. I think we can do without those non-breaking spaces in general, though: Either there's no linebreak and all is well, or we do need a line break, and in that case it's better to break before the paren than have an overfull box.
There was a problem hiding this comment.
Let me disagree here. LaTeX might very well reflow the entire paragraph (without causing an overfull hbox) to avoid a linebreak at the tilde. I think it's good practice not to have a cross-reference at the start of a line. Is there a way to tell LaTeX "I don't want you to linebreak here, but before you produce an Overfull hbox, do it nonetheless"? If we can't do that, we have to consider the few cases where ~\ref produces an Overfull hbox on an individual basis.
There was a problem hiding this comment.
You could make a space with a positive but non-infinite penalty. But that's going too far; we can keep the non-breaking space and remove it on a case-by-case basis.
There was a problem hiding this comment.
@jwakely Good point, thanks. Patch amended.
|
|
No description provided.