consistent whitespace in \tcode types #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. The patch performs as advertised. |
|
Typos in the commit text:
|
Where a type contains embedded whitespace, such as 'long long',
the tex files have been inconsistent in rendering this as
'\tcode{long long}' or '\tcode{long} \tcode{long}', even within
a list of such types.
This patch consistently reduces the number of \tcode macros
by combining whitespaced keywords into a single \tcode element.
There may be some minimal kerning adjustments through the use of
non-proportional whitespace, but I don't immediately see any
text reflowing. The end result is source for the standard that
is easier to grep.
AlisdairM
force-pushed
the
simplifying_tcode_type
branch
from
685b5f8
to
baf9c8b
Compare
|
Fixed typos in commit message, and re-pushed. No change of content. |
|
Do you have a diffpdf? |
|
@AlisdairM: Ping |
|
I'm not convinced this actually looks better -- a proportional space looks tidier in body text --, but there is certainly something to be said for maintainability, and the majority of use cases already put multiword types into a single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where a type contains embedded whitespace, such as 'long long',
the tex files have been inconsistent in rendering this as
'\tcode{long long}' or '\tode{long} \tcode{long}', even within
a list of such types.
This patch consistently reduces the numbwr of \tcode macros
by combining whitespaced keywords into a single \txode element.
There may be some minimal kerning adjustments through the use of
non-proportional whitespace, but I don't immediately see any
tezt reflowing. The end result is source for the standard that
is easier to grep.