[temp] Replace \term with \defn or \placeholder #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eelis
reviewed
Jan 17, 2017
source/templates.tex
Outdated
| @@ -3556,11 +3561,11 @@ | |||
| \rSec2[temp.dep]{Dependent names} | |||
|
|
|||
| \pnum | |||
| \indextext{name!dependent}% | |||
| \indextext{dependent name|see{name!dependent}}% | |||
There was a problem hiding this comment.
Should this be see{name, dependent}?
|
Updated and rebased. |
zygoloid
reviewed
Feb 5, 2017
source/templates.tex
Outdated
| @@ -3704,7 +3708,8 @@ | |||
|
|
|||
| \pnum | |||
| A name refers to the | |||
| \term{current instantiation} | |||
| \indextext{current instantiation|see{instantiation, current}} | |||
| \defnx{current instantiation}{instantiation!current} | |||
There was a problem hiding this comment.
I don't think grouping this under "instantiation" is appropriate; the "current instantiation" is a notion separate from instantiation itself (in fact, it's most relevant when checking a template definition prior to performing any instantiation).
|
Fixed as requested. |
zygoloid
reviewed
Feb 6, 2017
source/templates.tex
Outdated
| A name is a | ||
| \term{member of the current instantiation} | ||
| \defnx{member of the current instantiation}{instantiation!member of the current} |
There was a problem hiding this comment.
This should be {current instantiation!member of} or similar.
zygoloid
reviewed
Feb 6, 2017
source/templates.tex
Outdated
| \indextext{instantiation!dependent member of the current}% | ||
| A name is a \term{dependent member of the current instantiation} if it is a | ||
| \indextext{dependent member of the current instantiation|see{instantiation, dependent member of the current}}% | ||
| A name is a \defnx{dependent member of the current instantiation}{instantiation!dependent member of the current} if it is a |
Thereby also improving the index.
|
Fixed the two "member of the current instantiation" issues. The index looks sane now (in this regard). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thereby also improving the index.
Partially addresses #329.