Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expr.cond] drop redundant subclause (CWG 2316) #1374

Merged
merged 1 commit into from Aug 17, 2020

Conversation

cubbimew
Copy link
Contributor

proposed fix for #1373

@jensmaurer
Copy link
Member

These words are quick to anger... For @zygoloid to decide whether this is editorial or needs CWG review.

@zygoloid
Copy link
Member

zygoloid commented Feb 5, 2017

I'm confident that the old and new words have the same meaning, but I'd like CWG review to double-check that we don't intend for these two cases to be handled differently any more. (As I recall, they did actually do different things before we reformulated this in terms of implicit conversion sequences in CWG1895.)

@zygoloid zygoloid added the cwg Issue must be reviewed by CWG. label Feb 5, 2017
@cubbimew
Copy link
Contributor Author

cubbimew commented Mar 3, 2017

resolved a conflict with cf283d8

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 2, 2018

@jensmaurer, @zygoloid: Did this PR ever come up in CWG?

@cpplearner
Copy link
Contributor

I suspect that CWG2316 is related, though I can't see the detailed description.

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 3, 2018

@cubbimew Rebase this regardless please if you don't mind, so that CWG can look at current wording.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 15, 2019

@cubbimew: rebase please?

@cubbimew
Copy link
Contributor Author

cubbimew commented May 19, 2020

rebased, sorry for delay (was in conflict against beb8815 )

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label May 19, 2020
@jensmaurer jensmaurer changed the title [expr.cond] drop redundant subclause [expr.cond] drop redundant subclause (CWG 2316) Aug 17, 2020
@jensmaurer
Copy link
Member

Approved by CWG telecon 2020-08-17.

@jensmaurer jensmaurer merged commit 89b3c61 into cplusplus:master Aug 17, 2020
@hubert-reinterpretcast
Copy link
Contributor

Not that anyone implemented it that I know of, but this reverts the resolution to CWG 2321 (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1113r0.html) adopted by the June 2018 Rapperswil meeting.

Compiler Explorer link demonstrating (at this time) non-adoption of the resolution to CWG 2321: https://godbolt.org/z/f8KqaM.

@opensdh
Copy link
Contributor

opensdh commented Aug 18, 2020

I don't understand, now, how that resolution was necessary anyway: if you fall through to the other bullet in the issue's example, isn't the target type A, to which const B can be implicitly converted?

jensmaurer added a commit that referenced this pull request Aug 18, 2020
Initial CWG analysis during the 2020-08-17 telecon approved
the change as editorial. However, further analysis revealed
that the change reverts CWG2321, which is unintended and
certainly not editorial.

This reverts commit 89b3c61.
@jensmaurer
Copy link
Member

jensmaurer commented Aug 18, 2020

The change was reverted in 0247412 because the change reverts the normative effects of CWG 2321. Such action is not editorial, and furthermore unintended.

@hubert-reinterpretcast
Copy link
Contributor

I don't understand, now, how that resolution was necessary anyway: if you fall through to the other bullet in the issue's example, isn't the target type A, to which const B can be implicitly converted?

Maybe that's why MSVC accepts but with different cv-qualification for the result than CWG 2321 would give.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants