Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp.concat] In example code comment, remove unnecessary line break and format code as code. #1377

Merged
merged 1 commit into from Feb 5, 2017

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jan 18, 2017

The comment easily fits on one line:

diff

(See [expr.dynamic.cast]/5 for a code comment that already has identical formatting.)

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 18, 2017

Thanks, but I'm already working on making changes like that on a larger scale. I'll get to that file eventually. This is definitely on the radar.

@tkoeppe tkoeppe closed this Jan 18, 2017
@Eelis
Copy link
Contributor Author

Eelis commented Jan 18, 2017

Ok cool, is there a relevant issue already?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 18, 2017

No, I don't think so. It's not like anything is actually wrong...

@Eelis
Copy link
Contributor Author

Eelis commented Jan 18, 2017

Well, we very routinely use issues to track cases of inconsistent formatting, right?

(Is it possible you're only looking at the line break removal and not the addition of missing \tcode? Because we've definitely treated missing \tcode as "wrong" in the past...)

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 18, 2017

I'm kind of looking at everything. That's why there's no issue. "Perform continual editorial review", if you will.

@jensmaurer
Copy link
Member

@tkoeppe: I'm sorry, I don't understand why you closed this. I appreciate you're going through the whole standard fixing formatting, but this particular change seems fine on its own, does not introduce inconsistencies, and does materially improve the formatting for this example.

So, let's apply it.

@jensmaurer jensmaurer reopened this Jan 18, 2017
@zygoloid zygoloid merged commit 73e107a into cplusplus:master Feb 5, 2017
@Eelis Eelis deleted the codecomment branch February 5, 2017 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants