Hyphenate 'pointer-to-member' when it is an adjective. #1386
Conversation
|
Looks good, will leave to @zygoloid to merge. |
| @@ -524,21 +524,21 @@ | |||
| object. The null pointer value is converted to the null pointer value of | |||
| the destination type. | |||
|
|
|||
| \rSec1[conv.mem]{Pointer to member conversions} | |||
| \rSec1[conv.mem]{Pointer-to-member conversions} | |||
There was a problem hiding this comment.
I'm concerned that this change suggests a false parallel: previously, all the "X-to-Y conversion"s converted an X into a Y. A pointer to member conversion definitely does not convert a pointer into a member. I'm also still trying to decide if the rules for adjectives really apply here; "pointer to member type" seems more like "office chair store" (which would not be written as "office-chair store") than like, say, "office-themed store".
We have quite a few other cases (such as "pointer to function types") that follow a similar non-hyphenation pattern. These seem quite natural to me as-is.
There was a problem hiding this comment.
We have 15 appearances where "pointer-to-member" is, in fact, hyphenated, so I presume you would accept a patch that removes the hyphens there?
There was a problem hiding this comment.
Let's discuss this at Kona and agree on a rule, then apply it consistently.
There was a problem hiding this comment.
We decided that we can get over this. Fine as written.
tkoeppe
added
the
needs rebase
|
I stole this commit, rebased it, added the definition of "pointer-to-member type", and committed this as cbd25c4. |
jensmaurer
removed
the
needs rebase
Fixes #1369.