Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp.pragma.op] Add missing \pnums and remove unwanted paragraph breaks. #1387

Merged
merged 1 commit into from Jan 20, 2017

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jan 18, 2017

[cpp.pragma.op] currently lacks numbered paragraphs altogether.

@@ -1387,6 +1387,7 @@
\indextext{macro!pragma operator}%
\indextext{operator!pragma|see{macro, pragma operator}}

\pnum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also move the example into the same paragraph, otherwise we don't really have just "one paragraph".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or add another \pnum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also everywhere else below please. Sorry, I hadn't spotted that right away.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, done. No additional visual changes.

@Eelis Eelis changed the title [cpp.pragma.op] Add missing \pnum. [cpp.pragma.op] Add missing \pnums. Jan 18, 2017
@@ -1402,6 +1403,7 @@
\grammarterm{pp-tokens} in a pragma directive. The original four preprocessing
tokens in the unary operator expression are removed.

\pnum
\begin{example}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this pointless newline while you're at it. We got over whatever made us have those back in the day.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Eelis Eelis changed the title [cpp.pragma.op] Add missing \pnums. [cpp.pragma.op] Add missing \pnums and remove unwanted paragraph breaks. Jan 20, 2017
@tkoeppe tkoeppe merged commit 4bbb3ba into cplusplus:master Jan 20, 2017
@Eelis Eelis deleted the pragma branch January 20, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants