Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out ellipses when they mean "more code here" rather than an actual ellipsis token. #1393

Closed
wants to merge 1 commit into from

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jan 20, 2017

Fixes #1390

@jwakely
Copy link
Member

jwakely commented Jan 20, 2017

Because most of those cases become well-formed code with this change, it could be argued that the ellipsis implies there's nothing but a comment there :-) What we have today isn't valid C++ and so is obviously meant to indicate something missing from the example. I'm not objecting to the change, but I don't think it's strictly necessary either.

@Eelis
Copy link
Contributor Author

Eelis commented Jan 20, 2017

I have no preference beyond consistency :)

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 20, 2017

I agree, the status quo doesn't seem to be bad, broken or confusing.

Regardless, please provide a screenshot.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 15, 2017

Seems like there's no consensus for change nor anyone violently fighting for this change. I'll close this; please reopen if you feel strongly.

@tkoeppe tkoeppe closed this Feb 15, 2017
@Eelis Eelis deleted the ellipsis branch January 9, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants