Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unord.req] variable p should be q in table #1423

Closed
lynnboy opened this issue Feb 3, 2017 · 1 comment
Closed

[unord.req] variable p should be q in table #1423

lynnboy opened this issue Feb 3, 2017 · 1 comment
Assignees
@jensmaurer

Comments

@lynnboy
Copy link

lynnboy commented Feb 3, 2017

https://github.com/cplusplus/draft/blob/master/source/containers.tex#L2471
in table tab:HashRequirements, the a.insert(p, t) item should be a.insert(q, t).
@cpplearner
Copy link
Contributor

Per LWG 2540, p is correct. But https://github.com/cplusplus/draft/blob/master/source/containers.tex#L2478 should be changed to use p instead of q.

jensmaurer added a commit to jensmaurer/draft that referenced this issue Feb 7, 2017
@jensmaurer
[unord.req] Insert hint is 'p', not 'q'
b5d676d 
LWG 2540 changed the hint for insert from 'q'
(a valid and dereferenceable iterator) to 'p'
(a valid, but not necessarily dereferenceable iterator),
but neglected to adjust the description text.

Fixes cplusplus#1423.
@jensmaurer jensmaurer self-assigned this Feb 7, 2017
@jensmaurer jensmaurer mentioned this issue Feb 7, 2017
Merged
jwakely pushed a commit that referenced this issue Feb 9, 2017
@jensmaurer @jwakely
[unord.req] Insert hint is 'p', not 'q' (#1440)
473966e 
LWG 2540 changed the hint for insert from 'q'
(a valid and dereferenceable iterator) to 'p'
(a valid, but not necessarily dereferenceable iterator),
but neglected to adjust the description text.

Fixes #1423.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lynnboy @cpplearner @jensmaurer