Add missing \tcode. #1431
Merged
Add missing \tcode. #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Feb 5, 2017
source/compatibility.tex
Outdated
| @@ -742,7 +742,7 @@ | |||
| \rationale | |||
| When classes become complicated, allowing such a redefinition | |||
| after the type has been used can create confusion for \Cpp | |||
| programmers as to what the meaning of 'I' really is. | |||
| programmers as to what the meaning of '\tcode{I}' really is. | |||
There was a problem hiding this comment.
The quotes are bogus. It should say:
`\tcode{I}'
|
Rebased, and added the drive-by punctuation fix @tkoeppe suggested. |
zygoloid
reviewed
Feb 6, 2017
source/compatibility.tex
Outdated
| @@ -742,7 +742,7 @@ | |||
| \rationale | |||
| When classes become complicated, allowing such a redefinition | |||
| after the type has been used can create confusion for \Cpp | |||
| programmers as to what the meaning of 'I' really is. | |||
| programmers as to what the meaning of `\tcode{I}' really is. | |||
There was a problem hiding this comment.
Fine with me. @tkoeppe would that work for you?
There was a problem hiding this comment.
Yes, no quotes is good, too.
|
Looks good to me. |
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://eel.is/tcodediffs.pdf (45 pages)