Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[istreambuf.iterator] Join subsections for operations descriptions. #1449

Closed
wants to merge 1 commit into from
Closed

[istreambuf.iterator] Join subsections for operations descriptions. #1449

wants to merge 1 commit into from

Conversation

jensmaurer
Copy link
Member

There was one subsection for every operator, yet everything
fits on half a page.

Fixes #1429.

@jensmaurer
Copy link
Member Author

jensmaurer commented Feb 8, 2017 •
edited

I'll inform Daniel Krügler about the changes for the stable names if this gets approved.

@jensmaurer
Copy link
Member Author

jensmaurer commented Feb 10, 2017 •
edited

This is a larger issue in all of [predef.iterators]; see #1429 for discussion.

@zygoloid zygoloid assigned jensmaurer and unassigned zygoloid Mar 3, 2017
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 20, 2017

@zygoloid, @jensmaurer: Is this for C++17? It looks like a nice and simple change; can we do this in isolation or would you prefer to only do it together with #1429 in one go?

@jensmaurer
Copy link
Member Author

jensmaurer commented Mar 20, 2017 •
edited

While this is a larger issue, other situations are less clear-cut than this one. So, I'd be happy to have this merged for C++17. Except that we need to augment the new "stable names migration" annex.

@jensmaurer
[istreambuf.iterator] Join subsections for operations descriptions.
bf2671a 
There was one subsection for every operator, yet everything
fits on half a page.

Fixes cplusplus#1429.
@jensmaurer
Copy link
Member Author

Updated for "stable names migration" annex. Note that "op!=" can't be mentioned, because the exclamation mark badly interacts with LaTeX "glossary" operations. Maybe there's some escape-foo to make it work? @godbyk?

@jensmaurer jensmaurer added this to the C++17 milestone Mar 20, 2017
@zygoloid
Copy link
Member

A glossary is a weird kind of index, so you probably need to escape the ! with ". I'll give that a go.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 20, 2017

@zygoloid: That'd be great, this has been bugging me for a very long time. Please check the .ilg logs to be sure that you've resolved all cases.

zygoloid pushed a commit that referenced this pull request Mar 20, 2017
@jensmaurer @zygoloid
[istreambuf.iterator] Join subsections for operations descriptions.
95cbc03 
There was one subsection for every operator, yet everything
fits on half a page.

Fixes #1429, #1449.
@zygoloid
Copy link
Member

That works, looking at other makeindex errors now.

@zygoloid zygoloid closed this Mar 20, 2017
@jensmaurer jensmaurer deleted the b9 branch March 20, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
C++17 DIS
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jensmaurer @tkoeppe @zygoloid