-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix destructor declaration indentation #1466
Conversation
I think this is intentional, so the destructor lines up with the constructor, and we do it in a few places: containers.tex: ~vector(); That doesn't mean we have to keep it though. |
Blech, I only looked at a couple which of course didn't use this device. It would be nice to pick a rule and be consistent throughout the standard. (See I'll repush with them all fixed. (Yes, I said "fixed." I'm totally unbiased.) |
The fact that |
12445e2
to
08ff86e
Compare
There's a consistent fix throughout. |
source/containers.tex
Outdated
@@ -4155,7 +4155,7 @@ | |||
\begin{itemdescr} | |||
\pnum | |||
\effects If \tcode{sz < distance(begin(), end())}, erases the last \tcode{distance(begin(), | |||
end()) - sz} elements from the list. Otherwise, inserts \tcode{sz - distance(begin(), end())} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please submit the trailing whitespace deletions as a separate pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CaseyCarter: Please rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
08ff86e
to
3b98d7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
..and apparently some trailing whitespace cleanup because my text editor hates it as much as I do.