Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destructor declaration indentation #1466

Merged
merged 1 commit into from Feb 18, 2017

Conversation

CaseyCarter
Copy link
Contributor

..and apparently some trailing whitespace cleanup because my text editor hates it as much as I do.

@jwakely
Copy link
Member

jwakely commented Feb 14, 2017

I think this is intentional, so the destructor lines up with the constructor, and we do it in a few places:

containers.tex: ~vector();
iostreams.tex: ~Init();
iostreams.tex: ~path();
iostreams.tex: ~file_status();
iostreams.tex: ~directory_entry();
iostreams.tex: ~directory_iterator();
iostreams.tex: ~recursive_directory_iterator();
iterators.tex: ~istream_iterator() = default;
iterators.tex: ~ostream_iterator();
locales.tex: ~numpunct_byname();
numerics.tex: ~mask_array();
numerics.tex: ~indirect_array();
strings.tex: ~basic_string();
utilities.tex: ~allocator();

That doesn't mean we have to keep it though.

@CaseyCarter
Copy link
Contributor Author

we do it in a few places

Blech, I only looked at a couple which of course didn't use this device. It would be nice to pick a rule and be consistent throughout the standard. (See template< vs. template <)

I'll repush with them all fixed. (Yes, I said "fixed." I'm totally unbiased.)

@CaseyCarter
Copy link
Contributor Author

containers.tex: ~vector();

The fact that vector<bool> uses this device clearly indicates that it's very, very wrong.

@CaseyCarter CaseyCarter changed the title Teeny editorial fix in class path synopsis Fix destructor declaration indentation Feb 15, 2017
@CaseyCarter
Copy link
Contributor Author

There's a consistent fix throughout.

@@ -4155,7 +4155,7 @@
\begin{itemdescr}
\pnum
\effects If \tcode{sz < distance(begin(), end())}, erases the last \tcode{distance(begin(),
end()) - sz} elements from the list. Otherwise, inserts \tcode{sz - distance(begin(), end())}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please submit the trailing whitespace deletions as a separate pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkoeppe: See #1468.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaseyCarter: Please rebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tkoeppe tkoeppe merged commit 2c7c506 into cplusplus:master Feb 18, 2017
@CaseyCarter CaseyCarter deleted the path_ed_fix branch February 18, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants