Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[localization, diff] Omit superfluous 'return 0;' in main. #1482

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Feb 21, 2017

As far as I can tell, these are the only 4 occurrences (out of 33 main functions in the document).

@Eelis Eelis changed the title [localization, diff] Omit superflous 'return 0;' in main. [localization, diff] Omit superfluous 'return 0;' in main. Feb 21, 2017
@jensmaurer
Copy link
Member

Looks good to me, but I'm not sure there is a need to fix these. (However, I note these are not in the core section, where showing different programming styles is the intent.)

@Eelis
Copy link
Contributor Author

Eelis commented Feb 24, 2017

Oh, I don't know about "need", I just figured it would be nice for the example code fragments not to have unnecessary distractions in them. :)

@jwakely
Copy link
Member

jwakely commented Feb 24, 2017

I don't think these statements serve any purpose in these clauses, so I'd agree with removing them.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 24, 2017

Agree, not a relevant change, but we've probably spent enough time on it.

@tkoeppe tkoeppe merged commit fe6c8bd into cplusplus:master Feb 24, 2017
@Eelis Eelis deleted the mainret0 branch February 24, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants