Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macros] Remove terms-and-definitions entries from TOC and bookmarks #1493

Merged
merged 1 commit into from Mar 2, 2017

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Feb 27, 2017

Following the approach of http://stackoverflow.com/a/2785740.

@jwakely
Copy link
Member

jwakely commented Feb 27, 2017

It would be nice to update the preceding comment, "For ISO format use:"

@jwakely
Copy link
Member

jwakely commented Feb 27, 2017

Maybe remove the comment entirely. The commented-out \newcommand is old, and with this proposed change the comment "For ISO format use:" doesn't apply to the line that follows it. Updating the "usage:" to document \definitionx would be nice.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Feb 27, 2017

@jwakely: Done. As a drive-by, I also made the line break starred so we won't get a page break there.

@jwakely
Copy link
Member

jwakely commented Feb 27, 2017

I've adopted this for the Networking TS (cplusplus/networking-ts@eec1cc9)

@zygoloid zygoloid merged commit 685a565 into cplusplus:master Mar 2, 2017
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Mar 2, 2017

This change has the unfortunate effect of changing references from "3.x" to just "3".

@zygoloid, @jwakely: I'll look into this and will try to find a better solution that restores the references. I'll be in touch.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Mar 3, 2017

@jwakely: I changed the way I suppress the TOC entry in 7542c70, which is a superior solution. The first solution did not only break reference labels, but also modified the vertical layout slightly.

@tkoeppe tkoeppe deleted the notoc branch March 15, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants