Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stable names for Filesystem subclause #1506

Merged
merged 1 commit into from Mar 16, 2017

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Mar 3, 2017

Addresses #1502

This doesn't change the [class.*] names mentioned in the issue: [class.directory_entry], [class.rec.dir.itr], [class.directory_iterator], [class.file_status], [class.filesystem_status], [class.path]

@jensmaurer
Copy link
Member

jensmaurer commented Mar 3, 2017

I would actually prefer to have all stable filesystem labels start with "fs".

@jwakely
Copy link
Member Author

jwakely commented Mar 3, 2017

Sure, I can do that.

@jensmaurer
Copy link
Member

@jwakely: Please get approval from @zygoloid before doing that.

@zygoloid zygoloid added this to the C++17 milestone Mar 3, 2017
@zygoloid
Copy link
Member

zygoloid commented Mar 3, 2017

Yes, let's do it. Please put a mapping table into the commit message (for the editors' report) and let lwgchair know too.

@zygoloid
Copy link
Member

Please can you rebase?

[class.path] -> [fs.class.path]
[path.generic] -> [fs.path.generic]
[path.cvt] -> [fs.path.cvt]
[path.fmt.cvt] -> [fs.path.fmt.cvt]
[path.type.cvt] -> [fs.path.type.cvt]
[path.req] -> [fs.path.req]
[path.member] -> [fs.path.member]
[path.construct] -> [fs.path.construct]
[path.assign] -> [fs.path.assign]
[path.append] -> [fs.path.append]
[path.concat] -> [fs.path.concat]
[path.modifiers] -> [fs.path.modifiers]
[path.native.obs] -> [fs.path.native.obs]
[path.generic.obs] -> [fs.path.generic.obs]
[path.compare] -> [fs.path.compare]
[path.decompose] -> [fs.path.decompose]
[path.query] -> [fs.path.query]
[path.gen] -> [fs.path.gen]
[path.itr] -> [fs.path.itr]
[path.non-member] -> [fs.path.nonmember]
[path.io] -> [fs.path.io]
[path.factory] -> [fs.path.factory]
[class.filesystem_error] -> [fs.class.filesystem_error]
[enum.path.format] -> [fs.enum.path.format]
[enum.file_type] -> [fs.enum.file_type]
[enum.copy_options] -> [fs.enum.copy.opts]
[enum.perms] -> [fs.enum.perms]
[enum.perm_options] -> [fs.enum.perm.opts]
[enum.directory_options] -> [fs.enum.dir.opts]
[class.file_status] -> [fs.class.file_status]
[file_status.cons] -> [fs.file_status.cons]
[file_status.obs] -> [fs.file_status.obs]
[file_status.mods] -> [fs.file_status.mods]
[class.directory_entry] -> [fs.class.directory_entry]
[directory_entry.cons] -> [fs.dir.entry.cons]
[directory_entry.mods] -> [fs.dir.entry.mods]
[directory_entry.obs] -> [fs.dir.entry.obs]
[class.directory_iterator] -> [fs.class.directory_iterator]
[directory_iterator.members] -> [fs.dir.itr.members]
[directory_iterator.nonmembers] -> [fs.dir.itr.nonmembers]
[class.rec.dir.itr] -> [fs.class.rec.dir.itr]
[rec.dir.itr.members] -> [fs.rec.dir.itr.members]
[rec.dir.itr.nonmembers] -> [fs.rec.dir.itr.nonmembers]
@jwakely
Copy link
Member Author

jwakely commented Mar 16, 2017

Rebased. As shown in the commit message, the mappings are:

    [class.path] -> [fs.class.path]
    [path.generic] -> [fs.path.generic]
    [path.cvt] -> [fs.path.cvt]
    [path.fmt.cvt] -> [fs.path.fmt.cvt]
    [path.type.cvt] -> [fs.path.type.cvt]
    [path.req] -> [fs.path.req]
    [path.member] -> [fs.path.member]
    [path.construct] -> [fs.path.construct]
    [path.assign] -> [fs.path.assign]
    [path.append] -> [fs.path.append]
    [path.concat] -> [fs.path.concat]
    [path.modifiers] -> [fs.path.modifiers]
    [path.native.obs] -> [fs.path.native.obs]
    [path.generic.obs] -> [fs.path.generic.obs]
    [path.compare] -> [fs.path.compare]
    [path.decompose] -> [fs.path.decompose]
    [path.query] -> [fs.path.query]
    [path.gen] -> [fs.path.gen]
    [path.itr] -> [fs.path.itr]
    [path.non-member] -> [fs.path.nonmember]
    [path.io] -> [fs.path.io]
    [path.factory] -> [fs.path.factory]
    [class.filesystem_error] -> [fs.class.filesystem_error]
    [enum.path.format] -> [fs.enum.path.format]
    [enum.file_type] -> [fs.enum.file_type]
    [enum.copy_options] -> [fs.enum.copy.opts]
    [enum.perms] -> [fs.enum.perms]
    [enum.perm_options] -> [fs.enum.perm.opts]
    [enum.directory_options] -> [fs.enum.dir.opts]
    [class.file_status] -> [fs.class.file_status]
    [file_status.cons] -> [fs.file_status.cons]
    [file_status.obs] -> [fs.file_status.obs]
    [file_status.mods] -> [fs.file_status.mods]
    [class.directory_entry] -> [fs.class.directory_entry]
    [directory_entry.cons] -> [fs.dir.entry.cons]
    [directory_entry.mods] -> [fs.dir.entry.mods]
    [directory_entry.obs] -> [fs.dir.entry.obs]
    [class.directory_iterator] -> [fs.class.directory_iterator]
    [directory_iterator.members] -> [fs.dir.itr.members]
    [directory_iterator.nonmembers] -> [fs.dir.itr.nonmembers]
    [class.rec.dir.itr] -> [fs.class.rec.dir.itr]
    [rec.dir.itr.members] -> [fs.rec.dir.itr.members]
    [rec.dir.itr.nonmembers] -> [fs.rec.dir.itr.nonmembers]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants