Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent comma after e.g. and i.e. #1512

Closed

Conversation

AlisdairM
Copy link
Contributor

After grepping to determine the preferred idiom, it seems clear that
the standard prefers to follow both e.g. and i.e. with a comma, rather
than omit it. This patch applies that rule to the few places that
were missing the comma, including in LaTeX comments only for the editors'
benefit.

After grepping to determine the preferred idiom, it seems clear that
the standard prefers to follow both e.g. and i.e. with a comma, rather
than omit it.  This patch applies that rule to the few places that
were missing the comma, including in LaTeX comments only for the editors'
benefit.
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Mar 18, 2017
@@ -2257,7 +2257,7 @@
\end{example}

\begin{example}
One can make a class uncopyable, i.e. move-only, by using deleted
One can make a class uncopyable, i.e., move-only, by using deleted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like abuse of "i.e." -- uncopyable and move-only are not equivalent. More drastic rewording seems necessary here.

@@ -4057,7 +4057,7 @@
\pnum
\returns \tcode{true} if
\range{first}{last} is empty or if
\range{first}{last} is partitioned by \tcode{pred}, i.e. if all elements that satisfy \tcode{pred} appear before those that do not.
\range{first}{last} is partitioned by \tcode{pred}, i.e., if all elements that satisfy \tcode{pred} appear before those that do not.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More damage to the English language perpretrated by Strunk and White, but OK, this is the dominant American English style, so let's put up with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I believe the "comma after i.e." thing is totally misguided. Nobody knows what "i.e." and "e.g." means in the expanded form, plus it's Latin anyway, so the argument "oh, it's a complete sentence lookalike, so should have commas around it" is broken. (Have you ever seen the expanded form in English?). We don't put a comma after "but" or "where" either.

@@ -147,7 +147,7 @@
An \defn{execution agent} is an entity such as a thread that may perform work in parallel with
other execution agents. \begin{note} Implementations or users may introduce other kinds of
agents such as processes or thread-pool tasks. \end{note} The calling agent is determined by
context, e.g. the calling thread that contains the call, and so on.
context, e.g., the calling thread that contains the call, and so on.
Copy link
Member

@zygoloid zygoloid Mar 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we need both an 'e.g.' and an 'and so on' here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think the entire "e.g." part needs a more drastic rewrite. This just doesn't read well.
And what "call" are we talking about? A "function call" in the syntactic sense of [expr.call]?
Suggestion: "is determined by the context, such as the thread of execution that contains the invocation of the function." (This is consistent with [intro.multithread] p2.)

Oh, and does this note attempt to define the term "calling agent"? Then it would be totally misguided.

@jensmaurer
Copy link
Member

jensmaurer commented Mar 25, 2017

One argument why we want a comma after e.g. and i.e.: LaTeX gets the spacing wrong otherwise.
https://en.wikibooks.org/wiki/LaTeX/Tips_and_Tricks

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 25, 2017

@jensmaurer that issue should instead be fixed by either using an appropriate dictionary or by escaping the space, i.e. i.e.\ . But do check the before and after, I have a feeling that memoir already knows about "i.e." and "e.g.".

@jensmaurer
Copy link
Member

Editorial meeting consensus: Add definition of "partitioned by" and actually use that in all seven situations. Review all uses of "i.e.": if you specify a rule twice, at least one of them is wrong. Remove them. "e.g." should not be written in normative text, attempt to replace with "for example". Should only be used in notes. Also consider "[ Example ... ]" if containing at least a full sentence.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 7, 2017
@tkoeppe tkoeppe self-assigned this Nov 12, 2017
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 12, 2017

I can take this over. I'll probably create several commits for the various separate issues here. Leave it with me.

@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 12, 2017
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 21, 2017

Stolen and committed (finally) as deb9fb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants