New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expr.delete] Properly italicize the term 'delete array', as done elsewhere #1532
Conversation
I don't think any of these "alternative"s should be in italics except for the 1st ones in [expr.delete]/2 that (I think?) is supposed to be defining what the terms mean (even though they don't read like a definition). |
I can go either way. |
How do we normally use |
We're inconsistent, but it's meant to be only when we introduce the term. |
Then we should do what Dawn says! |
6b21b56
to
6e1f8b1
Compare
I've done what Dawn suggested. |
lgtm! But I think we might need to wait for the edits branch to be created before we can merge this, even though it's a minor fix. @zygoloid, what do you think? |
Should we be italicizing the first occurrence, even? This is not some grandiose term that we're defining to be referenced later; it is literally used only twice, and neither use is a definition. It seems much more like we're just using these terms to clarify what we mean by "first alternative" and "second alternative". So either we should be defining these two terms separately, and unitalicizing both uses, or we should just be unitalicizing both uses. |
I think the terms "delete array" and "delete object" are generally useful terms of art that we might want to reuse elsewhere (C.2.9 seems like it could perhaps use them in place of single-object delete and array delete, for instance), but I can see this not being important enough to provide formal definitions for them. I'm happy to do whatever the editors think is most appropriate, but if we go with formal definitions, perhaps we should modify p1 with: The first alternative is for non-array objects<ins> and is a delete object expression</ins>, and the second is for arrays<ins>and is a delete array expression</ins>. Or something along those lines, and then fix up the places where we say "first alternative" or "second alternative" to just say delete object or delete array expression. |
I much prefer the idea of actually defining these terms rather than implying a definition from a parenthetical. Can we give them better names at the same time? "single-object delete expression" and "array delete expression" seem much better than "delete object" and "delete array". |
4218744
to
e8c62be
Compare
I've updated the patch (sorry for the delay). |
source/expressions.tex
Outdated
second is an \defnx{array delete expression}{delete!array}. | ||
Whenever the \tcode{delete} keyword is immediately followed by empty square | ||
brackets, it shall be interpreted as the second alternative.\footnote{A lambda | ||
expression with a \grammarterm{lambda-introducer} that consists of empty square |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a stab at fixing the whitespace issue. I'll keep an eye on the CI builder.
cabf09f
to
d892082
Compare
I don't understand the CI build failure. "LaTeX Error: File `ulem.sty' not found" does not seem like something I broke with my patch? |
No, that's odd. @godbyk: Would you happen to have any idea why the Latex run is failing? |
Could you rebase this again? |
"array delete expression" as definitions, removing the italics when not appropriate.
9a3f2af
to
a0807db
Compare
I believe it's been properly rebased now. |
Elsewhere in this subclause, delete array and delete object are italicized on use; this makes this usage consistent. I spoke with Richard about it at the Kona meeting, and he mentioned this seemed like the correct way to fix it.