Skip to content

[fs] negation style needs to be harmonized with rest of document #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tkoeppe opened this issue Mar 14, 2017 · 0 comments
Closed

[fs] negation style needs to be harmonized with rest of document #1535

tkoeppe opened this issue Mar 14, 2017 · 0 comments
Assignees
@jensmaurer

Comments

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 14, 2017 •
edited
Loading

The filesystems subclause use the construction ""If !exists(p)" repeatedly, which should be rephrased in our usual way as "If exists(p) is false".

There are similar constructions for other predicate checks. Basically, all exclamation marks should be expunged from that subclause.
tkoeppe referenced this issue Mar 14, 2017
@tkoeppe
NB CA-4,5,8, US-75,76,79 (C++17 CD): P0430R2 File system library on n…
3a8d6c0 
…on-POSIX-like operating systems
jensmaurer added a commit to jensmaurer/draft that referenced this issue Mar 28, 2017
@jensmaurer
Change '!predicate' phrasing to 'predicate is false'.
6ae66c4 
Fixes cplusplus#1535.
@jensmaurer jensmaurer changed the title [fs] negation style needs to be harmoized with rest of document [fs] negation style needs to be harmonized with rest of document Mar 28, 2017
jensmaurer added a commit to jensmaurer/draft that referenced this issue Mar 28, 2017
@jensmaurer
[filesystems] Change '!predicate' phrasing to 'predicate is false'.
4e361a3 
Fixes cplusplus#1535.
@jensmaurer jensmaurer mentioned this issue Mar 28, 2017
Merged
@jensmaurer jensmaurer self-assigned this Mar 28, 2017
jensmaurer added a commit to jensmaurer/draft that referenced this issue Apr 8, 2017
@jensmaurer
[filesystems] Change '!predicate' phrasing to 'predicate is false'.
e36651d 
Fixes cplusplus#1535.
zygoloid pushed a commit that referenced this issue Apr 10, 2017
@jensmaurer @zygoloid
[filesystems] Change '!predicate' phrasing to 'predicate is false'.
98b3911 
Fixes #1535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoeppe @jensmaurer