Editorial fix in [namespace.def] #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An identifier makes an entity defined only through several known kind of declarations. Here the word "defined" would make "typedef int X; namespace X{}" unintentionally well-formed, because the name "X" is introduced by a non-definition(typedef declaration) and nothing named "X" is defined previous the namespace definition.
|
This is a change to normative wording that changes its meaning. It may be a fine change, but it's not an editorial issue. Perhaps @zygoloid could add a core issue. |
|
[basic.scope.declarative]p4 makes a program ill-formed if there's a prior declaration of the name that isn't a namespace, but I think there is something interesting going on here: the intent of this "shall [not] have been previously declared" wording in p2 and p3 seems to be to determine which of the two grammar rules should be used, but "shall" is the wrong word to use in p2, because the program is not ill-formed if we get there and "identifier" has previously been defined as a namespace. I'll submit a core issue on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An identifier makes an entity defined only through several known kind of declarations. Here the word "defined" would make "typedef int X; namespace X{}" unintentionally well-formed, because the name "X" is introduced by a non-definition(typedef declaration) and nothing named "X" is defined previous the namespace definition.