Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[any.modifiers] fix emplace return type for 'any' #1545

Merged
merged 1 commit into from Mar 16, 2017
Merged

[any.modifiers] fix emplace return type for 'any' #1545

merged 1 commit into from Mar 16, 2017

Conversation

AlisdairM
Copy link
Contributor

LWG issue 2857 was applied verbatim, without noticing
that 'ValueType' had been previously changed to 'T'.
This makes things consistent by choosing 'T' as the
simpler form, more consistent with 'optional' and
'variant'.

@AlisdairM
[any.modifiers] fix emplace return type for 'any'
594704e 
LWG issue 2857 was applied verbatim, without noticing
that 'ValueType' had been previously changed to 'T'.
This makes things consistent by choosing 'T' as the
simpler form, more consistent with 'optional' and
'variant'.
@jwakely
Copy link
Member

jwakely commented Mar 16, 2017 •
edited

This matches the intention of the changes to any, which were done because the "value type" that gets stored is the decayed type, so calling the undecayed type ValueType is misleading.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 16, 2017

@jwakely: merge that business

@jwakely jwakely merged commit ad33212 into cplusplus:master Mar 16, 2017
@AlisdairM AlisdairM deleted the fix_any_emplace_return branch March 17, 2017 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlisdairM @jwakely @tkoeppe