Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stmt.ranged] Do not use \grammarterm for begin-expr and end-expr. #1558

Merged
merged 1 commit into from Mar 19, 2017

Conversation

jensmaurer
Copy link
Member

No description provided.

respectively;

\item otherwise, \textit{begin-expr} and \textit{end-expr} are \tcode{begin(__range)}
\item otherwise, \placeholder{begin-expr} and \placeholder{end-expr} are \tcode{begin(__range)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensmaurer: This is fine, but when do we use literal __ and when do we use \xname?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't quite understand the question. What's \xname?

And yes, I'm not totally happy with __range instead of introducing some readable variable and saying its name is unique.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\xname adds double underscores, so we don't have to spell those out literally, and it takes care to add some small amount of whitespace so the two characters don't run together. I'm not sure if that motivation is ultimately justified, it's just a thing we have.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we should use \xname and \mname everywhere we currently have two literal underscores in C++ identifiers.

@tkoeppe tkoeppe merged commit 1eeee72 into cplusplus:master Mar 19, 2017
@jensmaurer jensmaurer deleted the b3 branch March 19, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants