New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta.unary.prop] Fix index entry for is_aggregate. #1581
Conversation
@@ -15926,7 +15926,7 @@ | |||
can be marked with \tcode{final}. \end{note} & | |||
If \tcode{T} is a class type, \tcode{T} shall be a complete type. \\ \rowsep | |||
|
|||
\indexlibrary{\idxcode{is_aggregate_signed}!class}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And why does is_signed have !class
below? Confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there is also an entry for 'is_signed!numeric_limits' :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense.
Huh, I already fixed this during the motion editing. My review comments for library motion 20b were:
|
@jwakely: Did you push that? |
I thought so, but it doesn't really matter now. |
I guess not, because I am shown as contributing to c92cb1c (the tip of the lwg-20b branch, which has the fix for the cv void spacing) but my local caf741d68c0854d2945062f833f841c779472e61 commit isn't on github. I must have fixed the first problem, pushed, fixed the second problem, and not pushed it. Oops. |
@jwakely: And you had one job! :-) |
Looks like a copy-paste mistake, because the next one is is_signed.
Note that '!class' makes sense for is_signed's index entry because there is also an entry for 'is_signed!numeric_limits', but there is no other is_aggregate in the stdlib, so I removed the '!class' (making it consistent with the index entries for e.g. is_final and is_abstract).