Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filesystems] Change '!predicate' phrasing to 'predicate is false'. #1583

Merged
merged 1 commit into from Apr 10, 2017

Conversation

jensmaurer
Copy link
Member

Fixes #1535.

@tkoeppe tkoeppe requested a review from jwakely March 28, 2017 20:38
@tkoeppe tkoeppe added this to the C++17 IS milestone Mar 28, 2017
@zygoloid
Copy link
Member

zygoloid commented Apr 8, 2017

Diffs look good, this is OK to merge if someone has checked that it's not introducing bad linebreaks or similar. (We've had overfull hboxes in this area previously, as I recall.)

@jensmaurer
Copy link
Member Author

jensmaurer commented Apr 8, 2017

Current HEAD show one overfull hbox with "fgrep -e Overfull -e .tex std.log":
Overfull \vbox (4.77557pt too high) has occurred while \output is active []

This branch, rebased on the HEAD, shows only that very same overfull hbox.

diffpdf shows no bad linebreaks for the changes, either.

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 8, 2017

@jensmaurer: Your so-called "hbox" has self-identified as a "vbox" and would like you to treat it as such.

@jensmaurer
Copy link
Member Author

Dear vbox,

Please accept my sincere apologies for mistreatment as a hbox.

Jens

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 8, 2017

Looks all good, no hboxes were disrespected as part of this pull request.

@zygoloid zygoloid merged commit 98b3911 into cplusplus:master Apr 10, 2017
@jensmaurer jensmaurer deleted the b3 branch April 11, 2017 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants