Do not use \tcode for non-syntax. #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eelis
reviewed
Mar 28, 2017
| \tcode{<valarray>} | ||
| as | ||
| \tcode{inline}. | ||
|
|
There was a problem hiding this comment.
Hmm, this is erasing the whole paragraph rather than just the tcode bit. Was that intended?
There was a problem hiding this comment.
Yes, the statement is entirely redundant with [global.functions] p1
It is unspecified whether any non-member functions in the C++ standard library are defined as inline (10.1.6).
and [member.functions] p1
It is unspecified whether any member functions in the C++ standard library are defined as inline (10.1.6).
There was a problem hiding this comment.
Ah ok, thanks, was just checking because this edit doesn't match the commit description.
|
Looks good, needs rebasing. |
tkoeppe
added
the
needs rebase
This applies to inline, public, protected, private, and friend. Fixes cplusplus#106.
jensmaurer
removed
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to inline, public, protected, private, and friend.
Fixes #106.