Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lib] Use nullptr, not 0, for null pointer values. #1586

Merged
merged 1 commit into from Mar 31, 2017
Merged

[lib] Use nullptr, not 0, for null pointer values. #1586

merged 1 commit into from Mar 31, 2017

Conversation

jensmaurer
Copy link
Member

Fixes #208.

@jensmaurer jensmaurer requested a review from jwakely March 29, 2017 18:26
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 31, 2017

Why fail all checks? Fail fewer checks please.

@jensmaurer
Copy link
Member Author

If you look at https://travis-ci.org/cplusplus/draft/builds/216464768
this only fails the "manual" build. And I can't find out why; the corresponding "job log" seems to be essentially empty.

@jensmaurer
Copy link
Member Author

Ok, I've rebased and repushed, without any further changes. Seems to have worked.

@tkoeppe tkoeppe merged commit dff391e into cplusplus:master Mar 31, 2017
@jensmaurer jensmaurer deleted the nullptr branch March 31, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jensmaurer @tkoeppe @jwakely