Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG 2260 and 'r' #1592

Closed
timsong-cpp opened this issue Mar 30, 2017 · 3 comments
Closed

LWG 2260 and 'r' #1592

timsong-cpp opened this issue Mar 30, 2017 · 3 comments
Assignees
@jwakely

Comments

@timsong-cpp
Copy link
Contributor

timsong-cpp commented Mar 30, 2017 •
edited

The P/R of LWG2260 (adopted in Kona '17) was written when the descriptive variable definitions (Table 27 in N4140) included a variable called r.

Then d2afc9a editorially removed that variable as unused, but the P/R of the issue was never updated. So now the allocator requirements table contains a dangling reference.
@jwakely jwakely self-assigned this Mar 30, 2017
@jwakely
Copy link
Member

jwakely commented Mar 30, 2017

Adding a row for r pushes the last row onto a new page, and then there's a \newpage, which creates an almost empty page. Removing the page break seems to be OK. @tkoeppe was that the one added because of the weird table spilling into the footer?

An alternative might be to use *p instead of r. That would be an expression of the correct type, but looks a bit strange to state the requirement on pointer_to in terms of a X::pointer object, because you wouldn't need to use pointer_to if you had p already.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 30, 2017

Feel free to put the r back in and remove the \newpage. The latter is situational.

@jwakely
Copy link
Member

jwakely commented Mar 30, 2017

I'm leaning towards using *p instead of r, and adding an assertion that the result is equal to p.

jwakely added a commit to jwakely/draft that referenced this issue Jul 10, 2017
@jwakely
[allocator.requirements] Fix pointer_to expression
f592d21 
Fixes cplusplus#1592
@jwakely jwakely mentioned this issue Jul 10, 2017
Merged
jwakely added a commit to jwakely/draft that referenced this issue Nov 24, 2017
@jwakely
[allocator.requirements] Fix pointer_to expression
7617d4d 
Fixes cplusplus#1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwakely jwakely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwakely @tkoeppe @timsong-cpp