first attempt to pull requests #16
Conversation
corrected to partial_sum and added new initializer syntax for constructed stream operators
provided some comments where I believe instead of != nullptr should actually read "shall be dereferenceable"
|
figured out how to create pull request |
| @@ -5340,7 +5340,7 @@ | |||
|
|
|||
| \pnum | |||
| \enternote This constructor allows creation of an \textit{empty} | |||
| \tcode{shared_ptr} instance with a non-NULL stored pointer. \exitnote | |||
| \tcode{shared_ptr} instance with a non-nullptr stored pointer. \exitnote | |||
There was a problem hiding this comment.
I'm not sure I agree with this change, shared_ptr never stores nullptr because you cannot have shared_ptr<nullptr_t> so it doesn't really make sense to say this constructor allows an instance to not store nullptr. I would suggest "non-null" (in lowercase) or "empty shared_ptr instance with a stored pointer that is not equal to nullptr"
There was a problem hiding this comment.
you are right. I was wrong and over-enthusiastic to get rid of NULL.
How should I proceed, withdraw and retry?
On 27.05.2012, at 04:22, Jonathan Wakely wrote:
@@ -5340,7 +5340,7 @@
\pnum
\enternote This constructor allows creation of an \textit{empty}
-\tcode{shared_ptr} instance with a non-NULL stored pointer. \exitnote
+\tcode{shared_ptr} instance with a non-nullptr stored pointer. \exitnoteI'm not sure I agree with this change, shared_ptr never stores
nullptrbecause you cannot haveshared_ptr<nullptr_t>so it doesn't really make sense to say this constructor allows an instance to not store nullptr. I would suggest "non-null" (in lowercase) or "emptyshared_ptrinstance with a stored pointer that is not equal tonullptr"
Reply to this email directly or view it on GitHub:
https://github.com/cplusplus/draft/pull/16/files#r886020
Prof. Peter Sommerlad
Institut für Software: Bessere Software - Einfach, Schneller!
HSR Hochschule für Technik Rapperswil
Oberseestr 10, Postfach 1475, CH-8640 Rapperswil
http://ifs.hsr.ch http://cute-test.com http://linticator.com http://includator.com
tel:+41 55 222 49 84 == mobile:+41 79 432 23 32
fax:+41 55 222 46 29 == mailto:peter.sommerlad@hsr.ch
Hi Stefanus,
still a newbie in handling github. Jonathan explained a bit for me, and one of my commits actually contains unwanted temporary files, but I cannot figure out how to remove them from the commit. But I hope at least you can do the cherry picking.
I included what I previously sent you via email.
Regards
Peter.