Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filesystem_error.members] what() function to use non-existant function native_string() #1629

Closed
BoPersson opened this issue May 17, 2017 · 7 comments
Closed

[filesystem_error.members] what() function to use non-existant function native_string() #1629

BoPersson opened this issue May 17, 2017 · 7 comments
Labels
lwg Issue must be reviewed by LWG.

Comments

@BoPersson
Copy link

The description fo the what() function says:

"Returns: A string containing runtime_error::what(). The exact format is unspecified. Implementations
are encouraged but not required to include path1.native_string() if not empty, path2.native_-
string() if not empty, and system_error::what() strings in the returned string."

The native_string() should likely be just string().
@jwakely
Copy link
Member

jwakely commented May 17, 2017

More likely native()

@BoPersson
Copy link
Author

native() returns wstring on Windows, so cannot be used in an exception what-message.

@jwakely
Copy link
Member

jwakely commented May 17, 2017

Good point. My implementation uses string() but then there's no difference for POSIX. Boost also uses string().

@jensmaurer
Copy link
Member

Is this editorial? The fix seems normative.

@jwakely jwakely added the lwg Issue must be reviewed by LWG. label May 25, 2017
@jwakely
Copy link
Member

jwakely commented May 25, 2017

It's being dealt with as an LWG issue.

@jwakely jwakely closed this as completed May 25, 2017
@jwakely
Copy link
Member

jwakely commented May 25, 2017

Although it's arguably not normative, since native_string() doesn't exist, so the current wording is inconsistent, and it's only encouragement anyway.

@jwakely
Copy link
Member

jwakely commented May 25, 2017

http://cplusplus.github.io/LWG/lwg-active.html#2965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwakely @BoPersson @jensmaurer