Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[locale.moneypunct.virtuals] Footnote on moneypunct::do_curr_symbol could be more helpful #1646

Closed
jwakely opened this issue Jun 20, 2017 · 1 comment
Closed

[locale.moneypunct.virtuals] Footnote on moneypunct::do_curr_symbol could be more helpful #1646

jwakely opened this issue Jun 20, 2017 · 1 comment
Assignees
@jensmaurer
Milestone
C++20 IS

Comments

@jwakely
Copy link
Member

jwakely commented Jun 20, 2017

It's very hard to find out what the Intl template parameter of std::moneypunct is supposed to mean. [locale.moneypunct] says nothing about that template parameter. The only clue is a footnote in [locale.moneypunct.virtuals] which mentions

For international specializations (second template parameter true) this is typically four characters long, usually three letters and a space.

It would be helpful to refer to ISO 4217 codes. Maybe also mentioning somewhere that "international specializations" may have a different currency symbol.

Maybe all the footnotes in the [locale.categories] subclause should be notes, not footnotes.
@jensmaurer
Copy link
Member

How much of that is editorial? The utter lack of normative wording for the "International" template parameter can't be fixed editorially, it seems. We can certainly pimp the footnote to refer to ISO 4217, though.

The particular footnotes for std::moneypunct seem the right thing, because they give specific examples and hints for US locales instead of offering general remarks.

@jensmaurer jensmaurer changed the title Footnote on moneypunct::do_frac_digits could be more helpful [locale.moneypunct.virtuals] Footnote on moneypunct::do_curr_symbol could be more helpful Oct 20, 2017
jensmaurer added a commit to jensmaurer/draft that referenced this issue Oct 20, 2017
@jensmaurer
[locale.moneypunct.virtuals] Add reference to ISO 4217.
8bf46d4 
Fixes cplusplus#1646.
@jensmaurer jensmaurer mentioned this issue Oct 20, 2017
Merged
@jensmaurer jensmaurer self-assigned this Oct 20, 2017
@jensmaurer jensmaurer added this to the C++20 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
C++20 IS
Development

No branches or pull requests
2 participants
@jwakely @jensmaurer