Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement of "*" and "&" inconsistent #166

Closed
sdutoit opened this issue Aug 29, 2013 · 5 comments
Closed

Placement of "*" and "&" inconsistent #166

sdutoit opened this issue Aug 29, 2013 · 5 comments
Assignees
@jensmaurer
Milestone
C++14 DIS nice-to...

Comments

@sdutoit
Copy link
Contributor

sdutoit commented Aug 29, 2013

The prevailing style is "int& foo" and "int* foo". I fixed pointers to be more consistent in ce29631; fix references too.
@jensmaurer jensmaurer mentioned this issue Nov 12, 2016
Closed
@jensmaurer jensmaurer added the big An issue causing a large set of changes, scattered across most of the text. label Nov 14, 2016
@jensmaurer jensmaurer removed the big An issue causing a large set of changes, scattered across most of the text. label Dec 7, 2016
jensmaurer added a commit to jensmaurer/draft that referenced this issue Dec 7, 2016
@jensmaurer
[lib] Adjust whitespace to attach & to the type, not the declarator-id.
e325e18 
Fixes cplusplus#166.
@jensmaurer jensmaurer mentioned this issue Dec 7, 2016
Merged
@jensmaurer jensmaurer self-assigned this Dec 7, 2016
tkoeppe pushed a commit that referenced this issue Dec 7, 2016
@jensmaurer @tkoeppe
[lib] Adjust whitespace to attach '&' to the type, not the declarator…
a891076 
…-id. (#1181)

Fixes #166.
timsong-cpp added a commit to timsong-cpp/draft that referenced this issue Dec 7, 2016
@timsong-cpp
[lib] More & and && adjustments for cplusplus#166
be4a528
@jlaire jlaire mentioned this issue Dec 7, 2016
Closed
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 7, 2016

Very unlikely do be done.

@tkoeppe tkoeppe reopened this Dec 7, 2016
tkoeppe pushed a commit that referenced this issue Dec 7, 2016
@timsong-cpp @tkoeppe
[lib] More & and && whitespace adjustments (#1183)
b5459f8 
In pursuit of #166.
@timsong-cpp
Copy link
Contributor

I did test several different regexes before submitting #1183 and didn't find anything else.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 8, 2016

Things that come to mind:

  • angle brackets
  • ellipses
  • decltype
  • casts (new- and old-style)

@timsong-cpp
Copy link
Contributor

I just looked again at every case of [[:space:]]&[^[:space:]] and [a-zA-Z)>._][[:space:]]&$ and every case of \& preceded by a space (for inline code).

The only one remaining is Tid \cv{} \& in the description of bind, but that one's odd because removing the space means attaching & to the placeholder cv.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 8, 2016

OK, thanks a lot for checking! Let's close this then.

@tkoeppe tkoeppe closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
C++14 DIS nice-to-haves
Development

Successfully merging a pull request may close this issue.

[iterators] Fix whitespace to attach & to the type jlaire/draft
4 participants
@sdutoit @tkoeppe @timsong-cpp @jensmaurer