[Editorial] Clarify UTF-8 character literal definition #1678
Conversation
The definition of UTF-8 character literals almost paralleled that of char16_t character literals, but there were a few differences; this commit removes those. One of the differences in particular was that the specification of the value of a UTF-8 character literal was missing the phrase "containing a single c-char", which is necessary both as the antecedent of "its" later in the sentence.
| is representable with a single UTF-8 code unit | ||
| (that is, provided it is in the C0 Controls and Basic Latin Unicode block). | ||
| is representable with a single UTF-8 code unit. | ||
| (That is, provided it is in the C0 Controls and Basic Latin Unicode block.) |
There was a problem hiding this comment.
I would prefer to change the char16_t wording to incorporate the parenthetical in the prior sentence rather than changing this wording to split it into a separate sentence.
There was a problem hiding this comment.
I would have too, but I chose this way because the char16_t wording has been around for longer. I can change it to the other version for both if other people prefer it too.
I didn’t see in the How to submit an editorial issue page whether you’d prefer an amended commit or a separate one; I would guess amended, and that I should also rebase while I’m at it?
There was a problem hiding this comment.
Yes, please amend and rebase this PR.
tkoeppe
added
the
needs rebase
|
Please reopen if you're still interested in this and have addressed the above comment. |
In [lex.ccon], the definition of UTF-8 character literals almost parallels the definition of
char16_tliterals, but there are a few differences.One of the differences was that the definition of UTF-8 character literals was missing a few words, making a later pronoun lack an antecedent which made sense.