[over.call.object] Reference postfix-expression in call syntax correctly #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix to make tests pass. |
|
Only the check-whitespace test was failing, and it seemed that the fix was already pending. In any case, I incorporated the fix in my branch. |
|
Yes, the fix is to rebase on master. |
|
Okay; I don't recall having tried force pushing to a branch with a pull request active before. First time for everything. |
The grammar production corresponding to the call syntax has _postfix-expression_ as the callee operand. [over.call.object] appears to refer to this operand as the _primary-expression_ in the syntax.
hubert-reinterpretcast
force-pushed
the
over_call_object_p1_grammar_ref_fix
branch
from
eabf95a
to
ee4aaf4
Compare
|
Oh boy, get used to force pushing to PR branches all the time as you start interacting with the OCD nitpick master editors over here :-) |
|
Is that (OCD nitpick)+(master) editors, (OCD)+(nitpick master) editors, ((OCD nitpick) master) editors, something else, all, or some? :-) |
|
Absolutely all of the above! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar production corresponding to the call syntax has postfix-expression as the callee operand. [over.call.object] appears to refer to this operand as the primary-expression in the syntax.