Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcl.decl, temp.deduct.type] Fix inappropriate uses of \grammarterm. #1692

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jul 29, 2017

No visible change.

@Eelis Eelis changed the title [dcl.decl, syntax, temp.deduct.type] Fix inappropriate uses of \grammarterm. [dcl.decl, temp.deduct.type] Fix inappropriate uses of \grammarterm. Jul 29, 2017
@@ -2105,16 +2105,16 @@

\pnum
In the \grammarterm{function-body}, a
\grammarterm{function-local predefined variable} denotes a block-scope object of static
\techterm{function-local predefined variable} denotes a block-scope object of static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like \defn would be a better choice here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about \defnx{function-local predefined variable}{variable!function-local predefined}?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@@ -2139,7 +2139,7 @@
\grammarterm{function-body}
is of the form
\tcode{= default ;}
is called an \grammarterm{explicitly-defaulted} definition.
is called an \techterm{explicitly-defaulted} definition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to \defnx{explicitly-defaulted}{definition!function!explicitly-defaulted}, and remove the \indextext above.

@Eelis
Copy link
Contributor Author

Eelis commented Oct 15, 2017

Rebased and amended.

@zygoloid zygoloid merged commit 1e66edb into cplusplus:master Oct 16, 2017
@Eelis Eelis deleted the gramterm branch October 17, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants