Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util.smartptr.shared.create]: Broken declaration by "\placeholder{}" macro #1696

Closed
Dani-Hub opened this issue Aug 1, 2017 · 1 comment
Closed

Comments

@Dani-Hub
Copy link
Member

Dani-Hub commented Aug 1, 2017

[util.smartptr.shared.create] before p2 shows a broken make_shared and allocate_shared prototype declaration presumably due to an incomplete \placeholder{} expansion. In addition, the variadic template parameter name Args is missing (I just checked p0674r1 and found that the omitted parameter seemed to be intended):

template<class T, ...>
shared_ptr<T> make_shared(\placeholder{args});
template<class T, class A, ...>
shared_ptr<T> allocate_shared(const A& a, \placeholder{args});
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 1, 2017

Thanks for reporting! Fixed by a35fb3e.

@tkoeppe tkoeppe closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants