Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[temp.constr.order]/p2 wrong definition for subsume #1699

Closed
burblebee opened this issue Aug 4, 2017 · 1 comment
Closed

[temp.constr.order]/p2 wrong definition for subsume #1699

burblebee opened this issue Aug 4, 2017 · 1 comment
Assignees
@jensmaurer
Milestone
C++20 IS

Comments

@burblebee
Copy link
Contributor

The spec places the definition of subsume in [temp.constr.order]/p2, but as I read it, subsume is defined in [temp.constr.order]/p1, with the qualification "as described below" to specify what must hold true in order to satisfy this definition. Can we turn these two paragraphs into a proper definition for subsume?

From my correspondence with Richard:

me:
This ([temp.constr.order]/p1) is the definition of subsume, not below. Below describes how to determine if P implies Q, as referenced here with "as described below". Please move definition here.

Richard:
I don't think I agree. We never define what "implies" means; this is just a warm-up sentence telling you informally what we're going to precisely define below. The definition below is the formal definition of "subsumes".

me:
As I read it, the "implies" part is defined "as described below", so it all works.
burblebee referenced this issue Aug 4, 2017
@zygoloid
P0734R0 Concepts
18b788b 
The introduction of 'concept' to two lists of entities in [basic] was
omitted, since these lists already include the more general 'template'.

[expr.prim.req.compound] Fix example to not be ill-formed due to an
unsatisfiable concept.
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 13, 2017
@jensmaurer
Copy link
Member

Editorial meeting consensus: Delete first 1.5 paragraphs of [temp.constr.order]. "Then, P subsumes Q..." stays (drop "Then"). Split footnote into two (for DNF and CNF) and attach to mentions in definition of "subsumes".

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 7, 2017
@jensmaurer jensmaurer mentioned this issue Nov 15, 2017
Merged
@jensmaurer jensmaurer self-assigned this Nov 15, 2017
@jensmaurer jensmaurer added this to the C++20 milestone Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
C++20 IS
Development

No branches or pull requests
2 participants
@burblebee @jensmaurer