Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++17 DIS comment 021] Review all 'must's and fix as appropriate #1733

Closed
zygoloid opened this issue Sep 6, 2017 · 6 comments
Closed

[C++17 DIS comment 021] Review all 'must's and fix as appropriate #1733

zygoloid opened this issue Sep 6, 2017 · 6 comments
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Milestone

Comments

@zygoloid
Copy link
Member

zygoloid commented Sep 6, 2017

No description provided.

@zygoloid zygoloid added the ballot-comment Response to an NB or ISO comment on a ballot label Sep 6, 2017
@zygoloid zygoloid modified the milestone: C++17 IS Sep 6, 2017
@jensmaurer
Copy link
Member

Let me suggest REJECT for C++17 due to the size of the task and the induced wording churn. We should target this for C++20 with priority, though.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 8, 2017

I thought @hubert-reinterpretcast said this comment only applies to a small number of instances that were newly introduces between the DIS and our c++17 branch? Maybe this isn't so hard to fix then.

@hubert-reinterpretcast
Copy link
Contributor

I did not make any statements with regards to this comment on the DIS ballot. In any case, the comment is on the DIS ballot, so it definitely was meant to refer to the instances that are present in the DIS.

@jensmaurer
Copy link
Member

@tkoeppe: You seem to be confused. This is an ISO Central Secretariat comment, talking about "throughout the document".

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 8, 2017

OK, never mind me then.

@zygoloid
Copy link
Member Author

Pull request #1747 converts a few of these.

Suggested response: ACCEPTED WITH MODIFICATION. The majority of uses of "must" are either indicating logical necessity, or (when in non-normative wording) the consequence of requirements specified elsewhere in the document. Other occurrences of "must" have been corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Development

No branches or pull requests

4 participants