Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta.trans.other] Consider referencing p2 from the aligned_storage and aligned_union rows in Table 50 #1757

Closed
timsong-cpp opened this issue Sep 27, 2017 · 3 comments · Fixed by #2447
Labels
lwg Issue must be reviewed by LWG.
Milestone

Comments

@timsong-cpp
Copy link
Contributor

In this case, we have a single-line normative paragraph, buried between a non-normative note and two lengthy paragraphs dealing with common_type, that adds a requirement to aligned_{storage,union}, without any hint in Table 50 that the specification of those templates in the table is incomplete. This seems suboptimal.

I'd suggest adding a cross reference in the table (make it "Note X"?). Or perhaps it'd be simpler to just add the sentence to the two rows it applies to?

@jensmaurer
Copy link
Member

jensmaurer commented Nov 1, 2017

It's not clear to me that "It is implementation-defined whether any extended alignment is supported (6.11)." applies to aligned_union at all. There is no way to pass a "size_t Align" to aligned_union, and the normative statement is immediately after the example about aligned_storage. For "aligned_union", the phrasing ought to be "It is implementation-defined whether a type with an extended alignment is supported."

@jwakely : What's your view?

@jensmaurer jensmaurer added this to the C++20 milestone Nov 1, 2017
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 2, 2017
@jensmaurer
Copy link
Member

Editorial meeting consensus: Turn p2 sentence into a note with xref to 6.11 (where the general normative statement resides), applying to both aligned_storage and aligned_union. Also add both places to impldef index (same entry).

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 7, 2017
@zygoloid zygoloid added the lwg Issue must be reviewed by LWG. label Nov 7, 2017
@jensmaurer
Copy link
Member

See LWG 3016.

burblebee pushed a commit that referenced this issue Nov 12, 2018
zygoloid pushed a commit that referenced this issue Nov 26, 2018
zygoloid added a commit that referenced this issue Nov 26, 2018
P0899R1 LWG 3016 is Not a Defect

Fixes #2428, fixes #1757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants