[travis] Make overfull hboxes a presubmit error. #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godbyk
reviewed
Oct 22, 2017
.travis.yml
Outdated
| - BUILD_TYPE=check-whitespace # check for whitespace at the ends of lines | ||
|
|
||
| script: | ||
| # Build std.pdf | ||
| - pushd source | ||
| - if [ "$BUILD_TYPE" = "latexmk" ]; then | ||
| latexmk -pdf std; | ||
| ! grep -Fe "Overfull \hbox" std.log; |
There was a problem hiding this comment.
Need to escape the backslash with another backslash.
|
The |
Also delete the "manual" check since "complete" subsumes "manual".
|
OK, thanks, in that case I'd prefer to not rerun redundant steps that we'd catch anyway. No need to waste compute resources and time. |
AaronBallman
pushed a commit
to AaronBallman/draft
that referenced
this pull request
Nov 15, 2017
Also delete the "manual" check since "complete" subsumes "manual".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also delete the "manual" check since "complete" subsumes "manual".
@zygoloid, @godbyk: Could you please take a look whether this looks right?