Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diff] Give numbers to changes. #1803

Closed
wants to merge 1 commit into from
Closed

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Nov 13, 2017

This follows the direction given in #1367.

Example:

a

@jensmaurer
Copy link
Member

Well, this is probably as good as we get visually in this otherwise not-really-pleasing annex.

@zygoloid
Copy link
Member

It seems a bit odd that the section number (which is part of the change description) is before the paragraph number. Putting a paragraph number before the section number might look a bit strange, though. Let's try adding a "Something:" before each such section number list, and moving the paragraph numbers before those.

Some possible options for the "Something": "Modified rule", "Affected wording", "See", "Clause or Subclause".

@zygoloid zygoloid added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 22, 2017
@jensmaurer
Copy link
Member

I've created #1837 which uses "Affected subclause" and also cleans up a few oddities in section references throughout [diff].

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 27, 2017

We'll probably use #1837 instead.

@tkoeppe tkoeppe closed this Nov 27, 2017
@Eelis Eelis deleted the changenums branch November 27, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants