Fix some more subscripts for T, also fix cv in a few places. #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Nov 21, 2017
source/utilities.tex
Outdated
| of \tcode{reference_wrapper}, then \tcode{Vi} is \tcode{Ui::type\&}, | ||
| otherwise \tcode{Vi} is \tcode{Ui}. | ||
| where \tcode{V1} and \tcode{V2} are determined as follows: Let $\tcode{U}_i$ be | ||
| \tcode{decay_t<$\tcode{T}_i$>} for each $\tcode{T}_i$. If $\tcode{U}_i$ is a specialization |
There was a problem hiding this comment.
This is odd now, because it says T1 above on line 938, but here you say T_1.
There was a problem hiding this comment.
Agreed, it's odd. However, T1, T2, V1, and V2 are actual template parameters, so I can't really use subscript on those. I guess I should drop that particular change and create a new editorial issue with tag "decision required" so that we can talk about it later.
There was a problem hiding this comment.
Correct, that's why I hadn't made such changes before. If we need the C++ identifier, we should just use that, or otherwise we need to introduce wording like "where T_i is Ti" etc. For abstract type lists, subscripting is good.
|
Dropped odd change that needs further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.