[unique.ptr] Remove definition of 'transfers ownership'. #1812
Conversation
|
I would like us to consider an alternative: retain the definition of transfer of ownership, and replace the repeated postconditions with
I'm weakly in favor of this alternative, to reduce duplication and give us somewhere central to talk about |
|
So, we would substantially shorten the existing postconditions. Hm.. The "transfer ownership" wording is imprecise regarding the deleter: It says "if the pre-transfer u.d maintained state, such state has been transferred to u2.d", but the move constructors actually say that we copy-constructor or move-construct the deleter. Oh, move-assignment actually shows code rather than weasely prose. |
jensmaurer
added
the
decision-required
source/utilities.tex
Outdated
| \effects Constructs a \tcode{unique_ptr} by transferring ownership from | ||
| \tcode{u} to \tcode{*this}. If \tcode{D} is a reference type, this | ||
| \effects Constructs a \tcode{unique_ptr} from | ||
| \tcode{u}. If \tcode{D} is a reference type, this | ||
| deleter is copy constructed from \tcode{u}'s deleter; otherwise, this | ||
| deleter is move constructed from \tcode{u}'s deleter. \begin{note} The | ||
| deleter constructor can be implemented with \tcode{std::forward<D>}. \end{note} |
There was a problem hiding this comment.
(Drive-by:) "The construction of the deleter" would be more correct here.
|
OK. The idea of using "transfers ownership" to mean the relevant set of rules doesn't work out, because the rules are different each time (we transfer the deleter in different ways, and may or may not reset the destination first). Let's go with this patch or something like it. |
zygoloid
removed
the
decision-required
It is mostly subsumed by the detailed descriptions of the move constructors and assignment operators.
It is mostly subsumed by the detailed descriptions of the move
constructors and assignment operators.
Fixes #1643.