New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swappable.requirements] Merge example's comment to one line #1829
[swappable.requirements] Merge example's comment to one line #1829
Conversation
I think I'd rather just get rid of the pointless line break, non? |
Of the surrounding comments, if that was done to the one below, it would merge the comments. Although it can be done for the one in the fix and the one above it, the current style is most general. What do you think? Do we keep the one below and remove them from the two above. |
swap(t1, t2); // OK: uses swappable conditions for lvalues of type \tcode{T} Oh, you mean like that? |
Yes. |
d586d1d
to
7bdb186
Compare
Done. |
Thanks! |
Looks good to me. |
Oh, wait, this would overrun the line, right? Can you render it and see what it looks like? I didn't realize how far out the comment is. If it doesn't fit, let's go back to the original proposal. |
I'll try rendering it. I think I've never done it before. However, I thought it was fine by looking at the code, as the comment's font should be mostly shorter than the code's monospaced font. |
Avoids having the comment over the closing brace.
7bdb186
to
1c4fdf5
Compare
Oh, does it actually fit? Great. |
I just tried it out locally; the change does not cause an overfull hbox. |
@jensmaurer: That's not relevant, though: what matters is that there isn't a line break. Long comments will happily go on as many lines as they need, all neatly justified. So the important check here was that it fits on one line. But it seems to! |
This follows the style of the surrounding comments.