Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CH-7: [intseq.general]/2 index_sequence instead of integer_sequence #183

Closed
sdutoit opened this issue Sep 19, 2013 · 5 comments
Closed

CH-7: [intseq.general]/2 index_sequence instead of integer_sequence #183

sdutoit opened this issue Sep 19, 2013 · 5 comments
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Milestone
C++14 CD NB Response

Comments

@sdutoit
Copy link
Contributor

sdutoit commented Sep 19, 2013

N3733 CH-7 says:

The example uses the names “index_sequence” and “make_index_sequence” whereas the following sections define “integer_sequence” and “make_integer_sequence”.

It goes on to propose:

Change the names in the example accordingly.
@jwakely
Copy link
Member

jwakely commented Sep 19, 2013

This issue is entirely incorrect, index_sequence and make_index_sequence are alias templates defined in the synopsis in 20.2 [utility] paragraph 2. Changing the names in the example would be wrong, because integer_sequence doesn't take the same template parameters as index_sequence.

@sdutoit
Copy link
Contributor Author

sdutoit commented Sep 19, 2013

Thanks Jonathan!

Please don't close it yet as I want to sync at next week's meeting on proper procedure for these first.

On Thu, Sep 19, 2013 at 11:41 AM, Jonathan Wakely
notifications@github.com wrote:

This issue is entirely incorrect, index_sequence and make_index_sequence are alias templates defined in the synopsis in [utility] paragraph 2. Changing the names in the example would be wrong, because integer_sequence doesn't take the same template parameters as index_sequence.

Reply to this email directly or view it on GitHub:
#183 (comment)

@sdutoit
Copy link
Contributor Author

sdutoit commented Sep 23, 2013

I agree with Jonathan's analysis.

sdutoit added a commit that referenced this issue Sep 24, 2013
@sdutoit
NB CH-7 (C++14 CD) [intseq.general] Clarify purpose of index_sequence.
5c5b671 
Add a note to clarify that, and why, index_sequence<> exists since it's
only specified in the summary.

Closes #183.
@PeterSommerlad
Copy link

Our fault (CH), we (I believe it was me only) missed the using aliases of index_sequence when stomping over that section....

Sorry for the confusion
Peter.
On 23.09.2013, at 21:29, Stefanus Du Toit notifications@github.com wrote:

I agree with Jonathan's analysis.

—
Reply to this email directly or view it on GitHub.

@sdutoit
Copy link
Contributor Author

sdutoit commented Sep 24, 2013

No problem; it is easy to miss so I'm adding a non-normative note making it
clearer.

On Tue, Sep 24, 2013 at 9:43 AM, Peter Sommerlad
notifications@github.comwrote:

Our fault (CH), we (I believe it was me only) missed the using aliases of
index_sequence when stomping over that section....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Milestone
C++14 CD NB Response
Development

No branches or pull requests
3 participants
@sdutoit @jwakely @PeterSommerlad