Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diff] Introduce numbered paragraphs #1837

Merged
merged 1 commit into from Nov 27, 2017
Merged

Conversation

jensmaurer
Copy link
Member

Alternative for #1803.

@zygoloid
Copy link
Member

Hmm. "Affected subclause:" is probably not quite what we want here, because it could be more than one section and it could be a clause rather than a subclause that we name. But other than that detail, this looks like it could be good. Can you provide a screenshot?

@jensmaurer
Copy link
Member Author

jensmaurer commented Nov 26, 2017

@zygoloid: I've attached the screenshot. I haven't found a [diff] section applying to an entire clause; it's always subclauses. And "Affected subclause" doesn't look so bad even if multiple subclause numbers follow.

diffnumber

@Eelis
Copy link
Contributor

Eelis commented Nov 26, 2017

Looks great, much nicer than my simplistic #1803!

Personally I think it might read even better if the "Change:" line came before "Affected subclause:".

@zygoloid
Copy link
Member

@jensmaurer Look at the first change in [diff.cpp03.library] for a "whole clause" case. In fact, that's a "whole 14 clauses" case, but it looks like it's the only example of its kind.

@jensmaurer
Copy link
Member Author

[diff.cpp03.library] is broken in a way, anyway: Why don't we have a similar paragraph for the other C++xy subclauses? Certainly, the library has evolved with each iteration of the standard.

@jensmaurer
Copy link
Member Author

It would be nice to say "Affected clause: 14-30", but \ref always produces "Clause" in front.

I've gone for "Affected: Clause 14 - Clause 30" for now:
diff-clause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants