Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo, missing "be" #1839

Merged
merged 1 commit into from Nov 25, 2017
Merged

Typo, missing "be" #1839

merged 1 commit into from Nov 25, 2017

Conversation

stbergmann
Copy link
Contributor

No description provided.

@jensmaurer
Copy link
Member

Thanks for your submission.

Please rephrase your commit message:

  • It should start with the stable label of the modified section in square brackets, e.g. [basic.def.odr].

(git rebase -i master, then force-push to your branch should do it)

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 23, 2017
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 25, 2017

I can actually change the commit message as part of the merge, so we can accept this this time.

@tkoeppe tkoeppe merged commit 63ccd05 into cplusplus:master Nov 25, 2017
@stbergmann stbergmann deleted the typo branch November 27, 2017 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stbergmann @jensmaurer @tkoeppe